Re: [Xen-devel] [PATCH RFC V2 02/45] xen/sched: use new sched_item instead of vcpu in scheduler interfaces

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Thu, 2019-05-09 at 07:36 +0200, Juergen Gross wrote:
> On 08/05/2019 18:35, George Dunlap wrote:
> > On 5/6/19 7:56 AM, Juergen Gross wrote:
> > > 
> > 'item' really seems like the wrong word here.  To me 'item' always
> > means
> > one thing; whereas what you're planning on doing is grouping
> > together
> > vcpus to schedule together; which would mean "unit" (as in, a
> > military
> > unit).
> > 
> > I realize changing it here probably means also changing it in the
> > next
> > 43 patches as well.
> 
> Only about 1000 lines to change.
> 
> TBH, replacing "item" with "unit" is doable via sed. Doing the same
> with
> (as Dario suggested) "entity" is more painful, as I would need to
> check
> coding style (line length, indentation) manually afterwards. 
>
Ah, right, I didn't spot that 'item' and 'unit' are the same length.
Makes sense.

> So Dario,
> would you be fine with "unit"? This might save me some hours of work.
> 
I guess I am, yes. I like it more than 'item' too and, as much as I
like 'entity', I agree it's not worth the extra effort.

Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel