Re: [Xen-devel] Xen GCC coverage ARM64 testing - Unexpected Trap: Data Abort

[Julien Grall <julien.grall@xxxxxxx>]

On 5/13/19 11:29 AM, Viktor Mitin wrote:
> > > aarch64-poky-linux-gcc   -DBUILD_ID -fno-strict-aliasing -std=gnu99
> > > -Wall -Wstrict-prototypes -Wdeclaration-after-statement
> > > -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2
> > > -fomit-frame-pointer
> > > -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF
> > > .handlereg.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -Werror
> > > -Wmissing-prototypes -I./include
> > > -I/home/c/w/rcar_h3_ubuntu1604_yocto/build/tmp/work/aarch64-poky-linux/xen/4.12.0.0+gitAUTOINC+fd2a34c965-r0/git/tools/libs/toolcore/../../../tools/include
> > >    -c -o handlereg.o handlereg.c
> > ... this looks like a tool building error when I only touch the
> > hypervisor part. Are you certain this is my patch and not another error
> > in Xen 4.12 (or any patch you have on top)?
> Julien, you are right, it was local environment build issue (sorry for that).
> Xen GCC coverage feature works well with Aarch64 with this patch.
> Checked both commands, xencov read and xencov reset - both work well
> (no crashes anymore).
>
> Please also note that use case mentioned in Xen documentation
> (xencov_split) is also ok with generated coverage.dat input:
> xen.git/xen$ ssh root@host xencov read > coverage.dat
> xen.git/xen$ ../tools/xencov_split coverage.dat --output-dir=/
> xen.git/xen$ geninfo . -o cov.info
> xen.git/xen$ genhtml cov.info -o cov/
> xen.git/xen$ $BROWSER cov/index.html
>
> --------
> Minor observation about coverage build procedure. Documentation states:
> "To build with coverage support, enable CONFIG_COVERAGE in Kconfig."
> However, to build it properly, it needs to enable coverage feature in
> two places - main xen make command line and hypervisor .config file.
> Is it expected way to build xen with coverage feature? If yes,
> probably we should improve (or at least document) it some day...
What is require on the make command line?

As usual, patches are welcomed ;).

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel