Re: [Xen-devel] [PATCH] pvshim: make PV shim build selectable from configure

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.05.19 at 13:17, <roger.pau@xxxxxxxxxx> wrote:
> So a user can decide whether to compile a PV shim as part of the tools
> build. Note that the default behavior is preserved, which is to build a
> PV shim when the target architecture is x86.

But the original behavior was so only when building x86_64 - see
the three lines you remove from tools/firmware/Makefile.

> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -492,4 +492,16 @@ AC_ARG_ENABLE([9pfs],
>  
>  AC_SUBST(ninepfs)
>  
> +AC_ARG_ENABLE([pvshim],
> +    AS_HELP_STRING([--disable-pvshim],
> +                   [Disable pvshim build (x86 only, enabled by default)]),
> +    [AS_IF([test "x$enable_pvshim" = "xno"], [pvshim=n], [pvshim=y])], [
> +    case "$target_cpu" in
> +        i[[3456]]86|x86_64)
> +           pvshim="y";;

As said in the earlier discussion - at least gcc-based tool chains
are unlikely to cope when on ix86. Together with the changed
default behavior I guess you're actively breaking the (32-bit
x86) build. At the very least you'd need to probe for a capable
(cross) tool chain. (Quite possibly a 32-bit build on a 64-bit
host would still work fine, but that's not enough imo.)

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel