[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] tools: remove blktap2 related code and documentation

>>> On 14.05.19 at 13:39, <wei.liu2@xxxxxxxxxx> wrote:
> On Tue, May 14, 2019 at 05:35:25AM -0600, Jan Beulich wrote:
>> >>> On 14.05.19 at 12:30, <wei.liu2@xxxxxxxxxx> wrote:
>> > Blktap2 is effectively dead for a few years.
>> > 
>> > Notable changes in this patch:
>> > 
>> > 0. Unhook blktap2 from build system
>> > 1. libxl no longer supports TAP disk backend, with appropriate assertions
>> >    added and some code paths now return ERROR_FAIL
>> And also appropriate error messages, allowing people to know
>> what needs changing without first digging through the sources?
> Yes there have always been appropriate error messages in the error
> paths.

Well, good to know, but it doesn't match my experience, so at the
very least I'm in doubt of your use of "always". But it's been a while,
iirc this was painful mainly when, over an extended period of time
(i.e. as they got used for testing), having switched domain configs
from xend to xl shape. Which is to say: I can't give any concrete
recent examples of unclear error messages.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.