Re: [Xen-devel] [PATCH v1 1/2] makefile: add support for *_defconfig targets

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 14.05.19 at 20:45, <Volodymyr_Babchuk@xxxxxxxx> wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -269,6 +269,9 @@ kconfig := silentoldconfig oldconfig config menuconfig 
> defconfig \
>  $(kconfig):
>       $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) 
> SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@

So the rule you add matches this one. Is there a reason ...

> +%_defconfig:

... why you can't simply add this to the kconfig variable set a few
lines up? Oh - newer make doesn't like mixing pattern and
non-pattern rules. Perhaps worth a brief comment, to justify the
redundancy? Or alternatively, how about using $(wildcard )
instead of a pattern rule, thus rejecting invalid targets right away,
rather than deferring to the recursive make to notice the error?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel