Re: [Xen-devel] [PATCH v1 1/2] makefile: add support for *_defconfig targets

[Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>]

Hello Jan,

Jan Beulich writes:

>>>> On 14.05.19 at 20:45, <Volodymyr_Babchuk@xxxxxxxx> wrote:
>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -269,6 +269,9 @@ kconfig := silentoldconfig oldconfig config menuconfig 
>> defconfig \
>>  $(kconfig):
>>      $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) 
>> SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@
>
> So the rule you add matches this one. Is there a reason ...
>
>> +%_defconfig:
>
> ... why you can't simply add this to the kconfig variable set a few
> lines up? Oh - newer make doesn't like mixing pattern and
> non-pattern rules.
Yes, my first intention was to add this rule to the kconfig variable.
Sadly make does not allows this

> Perhaps worth a brief comment, to justify the
> redundancy?
Sure, will add in the next version.

> Or alternatively, how about using $(wildcard )
> instead of a pattern rule, thus rejecting invalid targets right away,
> rather than deferring to the recursive make to notice the error?
I considered this, but I can't see how $(wildcard ) can be used.
AFAIK, $(wildcard ) expects to find a file, matching the wildcard.
But %_defconfig is the phony rule, so I can't imagine how to use
$(wildcard ) in this case.

On other hand, following rule checks the presence of required _defconfig file:

%_defconfig: arch/$(SRCARCH)/configs/%_defconfig

So, I can do in this way if you wish.

BTW, I'll add .PHONY: %_defconfig in the next version.

--
Best regards, Volodymyr Babchuk
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel