Re: [Xen-devel] [PATCH] x86emul: add support for missing {, V}PMADDWD insns

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.05.19 at 12:17, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 15/05/2019 09:23, Jan Beulich wrote:
>> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
>> @@ -6624,6 +6624,8 @@ x86_emulate(
>>      case X86EMUL_OPC_VEX_66(0x0f, 0xf3): /* vpsllq xmm/m128,{x,y}mm,{x,y}mm 
>> */
>>      case X86EMUL_OPC_66(0x0f, 0xf4):     /* pmuludq xmm/m128,xmm */
>>      case X86EMUL_OPC_VEX_66(0x0f, 0xf4): /* vpmuludq 
>> {x,y}mm/mem,{x,y}mm,{x,y}mm */
>> +    CASE_SIMD_PACKED_INT(0x0f, 0xf5):    /* pmaddwd {,x}mm/mem,{,x}mm */
>> +    case X86EMUL_OPC_VEX_66(0x0f, 0xf5): /* vpmaddwd 
>> {x,y}mm/mem,{x,y}mm,{x,y}mm */
> 
> Nothing on this path checks for SSSE3, AFAICT.

Of course not - the insn first got introduced with MMX, then
promoted with SSE2 and again with AVX and AVX2.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel