Re: [Xen-devel] [PATCH] coverage: GCC coverage libfdt Makefile fix

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, May 16, 2019 at 02:13:54PM +0300, Viktor Mitin wrote:
> The patch resolves 'xencov' crashes in case of Aarch64.
> 
> All the .init.* sections are stripped after boot,
> it means that anything in .init.data cannot be accessed anymore.
> The build system explicitly compiles any .init binary without gcov option.
> The problem is coming from libfdt.
> The entire library is moved to .init using:
> $(OBJCOPY) $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) $< $@
> So we need to tell the top Makefile to filter out libfdt.
> 
> Reported-by: Viktor Mitin <viktor.mitin.19@xxxxxxxxx>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Tested-by: Viktor Mitin <viktor.mitin.19@xxxxxxxxx>

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Although I would like to ask you to adjust the subject to be more
specific:

  coverage: filter out libfdt.o

if you agree, this can be done while committing.

Wei.


> ---
>  xen/common/libfdt/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile
> index d81f54b6b8..c075bbf546 100644
> --- a/xen/common/libfdt/Makefile
> +++ b/xen/common/libfdt/Makefile
> @@ -3,6 +3,7 @@ include Makefile.libfdt
>  SECTIONS := text data $(SPECIAL_DATA_SECTIONS)
>  
>  obj-y += libfdt.o
> +nocov-y += libfdt.o
>  
>  CFLAGS += -I$(BASEDIR)/include/xen/libfdt/
>  
> -- 
> 2.17.1
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel