Re: [Xen-devel] [PATCH] coverage: GCC coverage libfdt Makefile fix

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, May 16, 2019 at 11:37:33AM +0000, Julien Grall wrote:
> 
> 
> On 16/05/2019 12:26, Wei Liu wrote:
> > On Thu, May 16, 2019 at 02:13:54PM +0300, Viktor Mitin wrote:
> >> The patch resolves 'xencov' crashes in case of Aarch64.
> >>
> >> All the .init.* sections are stripped after boot,
> >> it means that anything in .init.data cannot be accessed anymore.
> >> The build system explicitly compiles any .init binary without gcov option.
> >> The problem is coming from libfdt.
> >> The entire library is moved to .init using:
> >> $(OBJCOPY) $(foreach s,$(SECTIONS),--rename-section .$(s)=.init.$(s)) $< $@
> >> So we need to tell the top Makefile to filter out libfdt.
> >>
> >> Reported-by: Viktor Mitin <viktor.mitin.19@xxxxxxxxx>
> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> >> Tested-by: Viktor Mitin <viktor.mitin.19@xxxxxxxxx>
> > 
> > Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > Although I would like to ask you to adjust the subject to be more
> > specific:
> > 
> >    coverage: filter out libfdt.o
> > 
> > if you agree, this can be done while committing.
> 
> There are more than that the title to fix on commit. The Signed-off-by 
> and does not match the From for instance.
> 
> I initially suggested the change, so Suggested-by would be more 
> suitable. And then Viktor needs to add his signed-off-by.
> 
> Also, could we also fix libelf at the same time?

+1. Viktor?

Wei.

> 
> Cheers,
> 
> -- 
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel