Re: [Xen-devel] Regression in xen-unstable due to commit 3802ecbaa9eb36

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, May 16, 2019 at 02:18:05PM +0200, Olaf Hering wrote:
> Am Thu, 16 May 2019 14:04:51 +0200
> schrieb Olaf Hering <ohering@xxxxxxxx>:
> 
> > There are quite a few checks for device_model_version, they would be all
> > wrong if the assert is removed, or changed back to QEMU_XEN. Perhaps we
> > can continue to live with that error. device_model_version could become
> > a local variable. If it is not set, assume the caller just wants the
> > memory size and enforce QEMU_XEN again within that function.
> 
> I think that is what should be done, just for the sake of
> libxl_domain_need_memory. If an incomplete b_info is provided, assume
> device_model_version=QEMU_XEN, maintain that state in a local variable.

I checked, libxl_domain_need_memory is actually the only public API
which takes b_info.

So this should work -- we just need to fix that one API to retain its
original behaviour.

> If we want to provide another new public API to fill missing defaults,
> that could still be done in a separate patch.
> 

Yes.

Wei.

> Olaf



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel