[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] libxc: elf_kernel loader: Remove check for shstrtab
- To: Wei Liu <wei.liu2@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 16 May 2019 14:38:07 +0100
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@xxxxxxxxxx; spf=SoftFail smtp.mailfrom=Andrew.Cooper3@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxxxxxxxxxxxxx
- Autocrypt: addr=andrew.cooper3@xxxxxxxxxx; prefer-encrypt=mutual; keydata= mQINBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABtClBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPokCOgQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86LkCDQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAYkC HwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA==
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
- Delivery-date: Thu, 16 May 2019 13:38:15 +0000
- Ironport-sdr: 7Rce/4sVYnFjyAtxIRdWeDXtmnv3zXhlnDHpf7NDUrEEiZY+DkIBaNbQGzOBNwRjk8Mb4EaUwc RQrQPKh2+Bb2sGQrZbMl2N4UnFXt6ornoxBxe1aYsC/JJB/f9exDfXW3ATww4u1eKTDxjiiUKT Kf0V6tnJqgia3h+M+hx8YM800JyN9OdHOpPjAXOKJLIRiNla9yJu7oqPU6MqIQ9aNKp+GpG2/Q pM8x9F1+8P6Nb2GVF2pkhWz6sXHkoAW9kFvfo2Dwx/CZNri+KsjBWrxeAAWHpx9vnCvccS1VQg Rc4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Openpgp: preference=signencrypt
On 16/05/2019 14:23, Wei Liu wrote:
> On Wed, May 15, 2019 at 01:55:30PM +0100, Anthony PERARD wrote:
>> On Wed, May 15, 2019 at 01:07:03PM +0100, Andrew Cooper wrote:
>>> On 15/05/2019 12:40, Anthony PERARD wrote:
>>>> This was probably useful to load ELF Note, but now ELF notes
>>>> "should live in a PT_NOTE segment" (elfnote.h).
>>>>
>>>> With notes living in segment, there are no need for sections, so there
>>>> is nothing to be stored in the shstrtab.
>>>>
>>>> This patch would allow to write a simpler ELF header for an OVMF blob
>>>> (which isn't an ELF) and allow it to be loaded as a PVH kernel. The
>>>> header only needs to declare two program segments:
>>>> - one to tell an ELF loader where to put the blob,
>>>> - one for a Xen ELFNOTE.
>>>>
>>>> The ELFNOTE is to comply to the pvh design which wants the
>>>> XEN_ELFNOTE_PHYS32_ENTRY to declare a blob as compaptible with the PVH
>>>> boot ABI.
>>>>
>>>> Note that without the ELFNOTE, libxc will load an ELF but with
>>>> the plain ELF loader, which doesn't check for shstrtab.
>>>>
>>>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>>> ---
>>>> tools/libxc/xc_dom_elfloader.c | 9 ---------
>>>> 1 file changed, 9 deletions(-)
>>>>
>>>> diff --git a/tools/libxc/xc_dom_elfloader.c
>>>> b/tools/libxc/xc_dom_elfloader.c
>>>> index 82b5f2ee79..b327db219d 100644
>>>> --- a/tools/libxc/xc_dom_elfloader.c
>>>> +++ b/tools/libxc/xc_dom_elfloader.c
>>>> @@ -165,15 +165,6 @@ static elf_negerrnoval xc_dom_parse_elf_kernel(struct
>>>> xc_dom_image *dom)
>>>> return rc;
>>>> }
>>>>
>>>> - /* Find the section-header strings table. */
>>>> - if ( ELF_PTRVAL_INVALID(elf->sec_strtab) )
>>>> - {
>>>> - xc_dom_panic(dom->xch, XC_INVALID_KERNEL, "%s: ELF image"
>>>> - " has no shstrtab", __FUNCTION__);
>>>> - rc = -EINVAL;
>>>> - goto out;
>>>> - }
>>> This might be fine for newer binaries, but you'll break older ones.
>>>
>>> Instead, you should skip searching for strtab if we've already located
>>> the Xen notes.
>> :-(, maybe I should have gone futher on explaining why this check is
>> useless (and probably at the wrong place, at least now).
>>
>> The next thing that's done after that check is:
>> elf_parse_binary()
>> elf_xen_parse()
>> Those are located in "xen/common/libelf", and those are the functions
>> that actually takes care of extracting data from the elf.
>>
>> elf_xen_parse() first look for Xen ELFNOTE in the program segments
>> (phdr, PT_NOTE) and skip reading section and strtab if found.
>>
>> So, libelf already does what you asked for ;-).
>>
>> The shstrtab are only used to look for legacy __xen_guest section names.
>> Since ELFNOTEs was used, the name of section aren't looked at.
>>
>> I hope that help.
>>
> Andrew, do you still have concern?
If libelf goes on to DTRT then fine, but this full explanation needs to
be in the commit message.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|