Re: [Xen-devel] [PATCH] libxl: fix libxl_domain_need_memory after 899433f149d

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, May 20, 2019 at 10:19:26AM +0100, Andrew Cooper wrote:
> On 20/05/2019 10:14, Roger Pau Monné wrote:
> >
> >> diff --git a/tools/libxl/libxl_mem.c b/tools/libxl/libxl_mem.c
> >> index 448a2af8fd..fe1f9c2ff8 100644
> >> --- a/tools/libxl/libxl_mem.c
> >> +++ b/tools/libxl/libxl_mem.c
> >> @@ -457,6 +457,24 @@ int libxl_domain_need_memory(libxl_ctx *ctx,
> >>      libxl_domain_build_info_init(b_info);
> >>      libxl_domain_build_info_copy(ctx, b_info, b_info_in);
> >>  
> >> +    /*
> >> +     * It has become a requirement that to figure out which QEMU to
> >> +     * use, libxl will need to peek d_config's content. The code has
> >> +     * been changed such that one will need to call
> >> +     * libxl__domain_set_device_model before calling
> >> +     * libxl__domain_build_info_setdefault inside libxl.
> >> +     *
> >> +     * This (problematic) public API is the only one which takes a
> >> +     * b_info, imposing the same requirement on the users of this
> >> +     * public API will break them.
> 
> This sentence doesn't quite parse.  You either want "b_info.  Imposing",
> or something like "b_info, and imposing".

Yep. Already fixed in my local copy.

I sent an email via xen.org address to that effect but it didn't come
through.

Wei.

> 
> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel