[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH 1/2] xen/device-tree: Add dt_count_phandle_with_args helper

On 20/05/2019 14:48, Oleksandr wrote:

On 20.05.19 14:03, Julien Grall wrote:

Hi, Julien

On 02/05/2019 15:13, Oleksandr Tyshchenko wrote:
From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>

Port Linux helper of_count_phandle_with_args for counting
number of phandles in a property.

Linux 5.1 uses a completely different implementation for of_count_phandle_with_args. So which version of Linux did you port from?

This patch is exactly the same one [1], I did more than 2 years ago in the context of non-shared IOMMU patch series. Likely, I was based on v4.4.

Sorry for the confusing description.

You are right, current implementation of_count_phandle_with_args is completely different, and I am afraid, is not easily back-portable to Xen.

If the implementation "v4.4" looks correct and fits in current Xen codebase, I can recollect an exact version and update the patch description.

What do you think?

The current implementation looks correct. So the commit message needs to be 


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.