Re: [Xen-devel] [PATCH MM-PART2 RESEND v2 01/19] xen/const: Extend the existing macro BIT to take a suffix in parameter

[Andrii Anisov <andrii.anisov@xxxxxxxxx>]

On 21.05.19 00:43, Stefano Stabellini wrote:
> On Tue, 14 May 2019, Julien Grall wrote:
> > Arm currently provides two macro BIT and BIT_ULL that are only usable
> > in C and return respectively unsigned long and unsigned long long.
> >
> > Extending the macros to deal with assembly would be a nice benefits as
> > it could replace the common pattern to define fields (AC(1, sfx) << X)
> > easier to read.
> >
> > Rather than extending the two macros, it was decided to drop BIT_ULL()
> > and extend the macro BIT() to take a suffix (e.g U, UL, ULL) in
> > parameter. This would allow to use different suffix without having to
> > define new macros.
> >
> > The new extend macro is now moved in include/xen/const.h so it can be
> > used by anyone in Xen and also avoid to include bitops.h in assembly
> > code.
> >
> > Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
 
Reviewed-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
--
Sincerely,
Andrii Anisov.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel