Re: [Xen-devel] [PATCH] x86: Fix boot with CONFIG_XSM enabled following c/s 7177f589ba

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.06.19 at 14:20, <andrew.cooper3@xxxxxxxxxx> wrote:
> "adjust system domain creation (and call it earlier on x86)" didn't account
> for the fact that domain_create() depends on XSM already being set up.
> 
> Therefore, domain_create() follows xsm_ops->alloc_security_domain() which is
> offset 0 from a NULL pointer, meaning that we execute the 16bit IVT until
> happening to explode in __x86_indirect_thunk_rax().
> 
> There is nothing very interesting which xsm_multiboot_init() more than
> allocating memory, which means it is safe to move earlier during setup.

The last sentence looks somewhat odd to me (the "which" in particular).
Perhaps you could rephrase that?

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

As to not considering XSM - I did specifically check that the respective
Flask function is fine. I forgot that there's an indirect call in between.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel