[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Thu, 18 Jul 2019 15:17:27 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dKtN4buhnUWAjc/Wquq1cAAwXQqTqd7mOk2z5GmO+Kc=; b=jTR0d0eSA4BCa3A4bvCllDUiAdHGpIPdhVwcIZ3l3aVNCMeNS9m7zcOpxTqMXZN3V57ujd4E3CsBw3BX7UcxnyaEgbcNZDK+K6KdEGfu6+I/ATFnz68K4sp1KbX0AcjpdXPi355QJZmJmOdfwNQ0D0hULxQD7ylgkRHjBGY/LU8qoBTC6i5+mGfxDTejNGdoJiPoLA01UwVtTK5eCReUkvl5IUGINV8oqsm3XXqbomWhNwLHDL02Uh2Yh+Yum4i5wHtuxYnieXRPmb2xEnlageZP4+cY8rBaimJ2nCLbR1p9nRRWHvXj5eMslnLa5a4SKfUkL9/O2DDRMcTFqKxuhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N99+ZxgM+tDrH01xoSQeeUbTDVpvZLB3OT4Y7ralhaD/+HPIHh7THgX4QwKZYi/1FezSKIvMmE2NoVs6qt1TaSLcXTuXL4tYLTD0c+QO3dGaR2zKPxvdXhmZtbPiFq/fir6zTTXoQOCARV7PLxGIYypg+cZxUeY974mDnU0SzVflxv7kRX2YoUsfvc750Ax1r2Sf7Jis7cTiSmdW4ldQHJJBlqXOzXejzgsc/uoZZmnuNMV9N3SxdlSWVpGOCGvIe2uOXyVxMNJozolE0UrTx5aTj9fzAqavQ1a/ZxfND/Ujq62DPGrsfH7XOEqbD+NKo4Fx2sHhqE8dXylj8W8Q6w==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, AndrewCooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, TimDeegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
- Delivery-date: Thu, 18 Jul 2019 15:18:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPW85l6TypzCOPUKKzJbbmldm3qbQfOwA
- Thread-topic: [PATCH v5 5/6] xen/x86: add PHYSDEVOP_msi_control
On 18.07.2019 15:46, Roger Pau Monné wrote:
> In fact I don't think INTx should be enabled when MSI(-X) is disabled,
> QEMU already traps writes to the command register, and it will manage
> INTx enabling/disabling by itself. I think the only check required is
> that MSI(-X) cannot be enabled if INTx is also enabled. In the same
> way both MSI caspabilities cannot be enabled simultaneously. The
> function should not explicitly disable any of the other capabilities,
> and just return -EBUSY if the caller attempts for example to enable
> MSI while INTx or MSI-X is enabled.
You do realize that pci_intx() only ever gets called for Xen
internally used interrupts, i.e. mainly the serial console one?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
