[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 04/60] xen/sched: use new sched_unit instead of vcpu in scheduler interfaces
- To: Juergen Gross <JGross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Thu, 18 Jul 2019 17:44:06 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=APFYO4eoqI8kNLaJ2IHeEF6LhYwroKdrOtoMlsbwt4A=; b=V0GPBGmypFo/cu0gjp0nkK0kuoHtSXp7JatitIu4Izw94HEu2wUhMsOGpAT8NN3is74lru6yEBAoIfelkIuAAfWFeXXXbE9G+tOCUmzPRo9l/PGOE8tSEclR0I3JToJZ6vUIrN0AAdP4AnPYpKRblmzcV1RD3VnNIjY8KhsFek+b8J+TUG+pD0Lxko1jQUIr05onB9535BFdF3I5R3/delTZvpk+tEZrN/eBZIlS5WCf/Io7WHCoF/7KeGD/3RYbRZguCLp3DtscI/XIBoo0k7WdY/PVB+3e8lJf2UyK04jwHySXuP95ya/yLp4ZDuOHrTtBBKOSCjBQO0J2gKjIoQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tkih6RiV6IIpffUPVplWDs75sFsclLl0kVj0tScAv63T0+sT0mJfv5+c32f82xny3/xcKNb++A07XYYSsrtP7ssDuctZ1YSVQxX2UAmg06sDkcRAk1CBOpBHAmgWbBJEiYLz7WhKj6oEWDCQkXQnDz904RCelnDLwRhCZzEmKqEcMvgXF2o2pG8N31FAWlqFFDLlWry9UD7AkM4gUEYF5+V+PXuW9NNEYTW7Zl0yilCsEIXMQGROw6AasnKKrNy2kPFHyvF5Y7mK+UVmrKpylv82EXC5O5/CQGCUtj2Lfgw2wKvw20+rRnQix+wMA8KIg87D3FEzX0ILirLwIdqb0Q==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=dfaggioli@xxxxxxxx;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "tim@xxxxxxx" <tim@xxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "robert.vanvossen@xxxxxxxxxxxxxxx" <robert.vanvossen@xxxxxxxxxxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, "josh.whitehead@xxxxxxxxxxxxxxx" <josh.whitehead@xxxxxxxxxxxxxxx>, "mengxu@xxxxxxxxxxxxx" <mengxu@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 18 Jul 2019 17:45:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPZBlL1Q1XUpsfEu/nRk5BkyHJw==
- Thread-topic: [Xen-devel] [PATCH 04/60] xen/sched: use new sched_unit instead of vcpu in scheduler interfaces
On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote:
> In order to prepare core- and socket-scheduling use a new struct
> sched_unit instead of struct vcpu for interfaces of the different
> schedulers.
>
> Rename the per-scheduler functions insert_vcpu and remove_vcpu to
> insert_unit and remove_unit to reflect the change of the parameter.
> In the schedulers rename local functions switched to sched_unit, too.
>
> For now this new struct will contain a vcpu pointer only and is
> allocated on the stack. This will be changed later.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
This looks good to me.
One thing that came to mind, is that the various function parameters
and local variables called 'unit', could be called 'su'.
It's a contraction of 'sched_unit', like, e.g., 'v' or 'vc' were
contractions of 'vcpu', it's still quite descriptive, it's short, which
is always good, IMO, and might mean less line wrap reformatting
(considering that it's replacing 'v' or 'vc').
Of course, this will likely mean changing all the other ~60 patches, so
I'll understand if you say that it would be too much.
Also...
> index 2201faca6b..72a17758a1 100644
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -275,6 +275,10 @@ struct vcpu
> struct arch_vcpu arch;
> };
>
> +struct sched_unit {
> + struct vcpu *vcpu;
> +};
> +
>
Is my understanding correct that this field is going to be renamed
vcpu_list, right from this patch?
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
