[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 05/60] xen/sched: alloc struct sched_unit for each vcpu
- To: Juergen Gross <JGross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Thu, 18 Jul 2019 17:57:05 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0IapSg9/YNi8AC+rfjEDIE8+wBO4dEeWdlCHx/6nnUw=; b=cuuBnho3ygMcHMa/K5uueIeyWO7BKy4U3TqUiVAn7yxaqImECdYR2dUcrAMeZjwRvS3+90e8lQtadxLeIdTWmZHHP0Q9BrxAxK4Tpmu0WJ0LekjtovF/UBDyyZTRdEErNe84CA1olrVT47LpMmqIrm24/X1IDCETcwsN6EIhh/sjjURu15DUJO+B9hdsiKG7u1dxgJAFyAHeGvqURqftsXf52uY5Zu9b6EOe+OWgm0/sV4H4Da7VHyGFX3ZW7171CrGMhCnL8/DGpzblq4oHwW53K+gXvJ5EC/juXfrNlHXkbhmStvV6QXlxCDR7VTuBWi/ueQ0Z6sZRk/9pt72oGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbKhpYZfVTBcf21ms/74gwNPidLMGG9j3lq4s1Ammm+FnCdHkij1NYMK+LW63vSZRnVbEkWG4O9chYRiDJgJD5cVPw7Op9k6ExuF1AQSBK2IVioK5xUmnbs7FT42Rc4VgdisqIYnVo/Jh4POtn4SwGfWrtmkAq4gMl1kpF0jxlOiRqKXn9GPKv1rvV2vkdX/mrSD5Pn7kv1mJQryuhlRFlrIwUFd/NnalIcceOgpXTRgksNPxL75VE1PZZ0affWodQv8Gnzossi8DXn9/ESEPmbNl/jYYjxmiXFDE4R355TpAyNXDmN+aYYXVSeKddLlN/pvx5vdITwVdpaLx5GKzg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=dfaggioli@xxxxxxxx;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "tim@xxxxxxx" <tim@xxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 18 Jul 2019 18:00:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPZI1eSV5JYG3wEiY4OjiJWJE7g==
- Thread-topic: [Xen-devel] [PATCH 05/60] xen/sched: alloc struct sched_unit for each vcpu
On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote:
> Allocate a struct sched_unit for each vcpu. This removes the need to
> have it locally on the stack in schedule.c.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
And this patch looks ok as well.
However, I don't see much value in not doing what's done here in patch
4 already (it's pretty much only line changed by patch 4 that are being
changed again here).
Is there a particular reason you think it's important to keep these two
patches separated?
Ah, my comment about 'unit' --> 'su' --in case you think it's feasible-
- applies to struct members as well, of course, e.g., here:
>@@ -160,6 +161,7 @@ struct vcpu
>
> struct timer poll_timer; /* timeout for SCHEDOP_poll */
>
> + struct sched_unit *sched_unit;
> void *sched_priv; /* scheduler-specific data */
>
> struct vcpu_runstate_info runstate;
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
