[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 1/2 RESEND] CODING_STYLE: explicitly call out label indentation
- To: Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Fri, 19 Jul 2019 13:21:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xjY8yoX4cT0UZtEcLVMCQt4QTUx/wTRBZV0nM6KY0Eg=; b=mEYfWk/mGBgAlXcOZxYjXCWulg1ua5JMlSG58IEmj63JNgoTog4RijQTNmxu5AQoLUpq+G8Po5SUEx5x9LQkjKnAAN9sjwAvUz0xreOoCkXfnppT0AubhL9sqMDfwJTd9xKMPseI+/ArNy3qtglWIY4NGon1F9dL9oe5VSpfPH6h/2ge6Og/FDEiIzAc00R/Wt/cPOKZR8KsNto7jf1zHe7sM+iQL8tThV3sZ8yq0o+0jHjkO4zBInIcLxtimk5FKgtApTkS6PxLyMtuOlboCmyRu0IooYFV7jSyiaolyh6rFZHO4Hu8AqSvtD1nWn/kwiesCcNOxuQ0aTpHgXe2Mw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L/v8fdknmGrApeq0q9hrBcCmOAiF9VLPraXHlUua3VCKe0mpH/PG+Ub0oHW53bwo2KT8SNSZleUpBeoSufCOABOsT1ZuQ6eEtJX2UwWFcVUh1tFr5tGcG+rINPE3fs0N/HmQCEeo2Tx+/qQVEUFuUrCn6ksl0FnkrRiHxcNoJEXhtDZ5+lal8j9yjDjuDjpntns8DGcU5PhMvjIFTX90od/F0ypJoheU+dv8S51cGxzoQut2fdUobOvp/EVIn00Asnb32e5f0/UG6EXZ8iCxojTIhasVQ9Ej5Xy53IIF5yBgBiuVaQrC8TrMqQqK+PsVqf3MAObKIfW1UZFekbYtZg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, JulienGrall <julien.grall@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 19 Jul 2019 13:22:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPhLyGXH0Q4NjDEWXJddchwyDaKbR7RTbgAAAmQA=
- Thread-topic: [Xen-devel] [PATCH 1/2 RESEND] CODING_STYLE: explicitly call out label indentation
On 19.07.2019 15:18, Tamas K Lengyel wrote:
> On Fri, Jul 19, 2019 at 3:19 AM Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>
>> Since the behavior of "diff -p" to use an unindented label as context
>> identifier often makes it harder to review patches, make explicit the
>> requirement for labels to be indented.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> This style requirement wouldn't really work with astyle as-is.
Personally I view proper "diff -p" context in patches as quite
a bit more important than automatic style checking. But perhaps
that's just because I do quite a lot of patch review ...
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
