[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 05/60] xen/sched: alloc struct sched_unit for each vcpu
- To: Juergen Gross <JGross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Fri, 19 Jul 2019 17:04:42 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VPeKIcVJqoLnvmImWG4QlpxVZ4SbkXLWk33fSE10SO8=; b=TRiIVXnekwl/G3zCx4UiTlSyJT3G0FY9SYMOeMrHbqyvwLYIRxyqur36vxtdoF1ly9NPdle2wJ4KYz54V7JCqoYejeDHFjUy+d/2wV/iquvyNq6FiDYHgXkL+ca9ZkMXt4lPe4VWSYSiU2nGh2pxgnLGIbxNIZ1tBdx668mA/tKqA820SjRIObo9MUrJlSZw4Fcg8HVQ1twjDtNxgGLOABq4r9HToMH4V7Q8S7a44XcsRCBm/ctCQjUzDUtOpWjZ31nVKV1hF6+WoACxGareeYP1xayvmQPZN6DR4YL+S0W/dp3fvGtijOFzSgwjKIqIE/kfHtEbgXNnUlAsaaMkWQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nodoBJs43E8ijfdpHWgqPKV8n/x7kSZrPzMW9KoKaxMG82cLsbYrbv51zkNcGpDgeiLjQEID8vVgjHJmaRrN5me/7Rb7NtMk0pQgy2N/t2HetyhPatYiXv7RW+xUqXvLQysRysnisEQ/zT3x2OZ8y7WD7YfZwO0S34zukXSne/xzYYbCdkTBCvpxrRRm1aee9BOHV8lg6w2H7dzHKG54sufPmxBVFxn33faYGBcFxiB/9Fq+bsBzMIRZ8ocs6lmRuNll57xU2uA/RHSbMV31CnQInCFC7iva1RvHJc85s9TQ25Z11Pwewmn5Bo9+QFq7NGWOwDFNVgkL1YEASWAo8w==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=dfaggioli@xxxxxxxx;
- Cc: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "wl@xxxxxxx" <wl@xxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>, "ian.jackson@xxxxxxxxxxxxx" <ian.jackson@xxxxxxxxxxxxx>, "tim@xxxxxxx" <tim@xxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Fri, 19 Jul 2019 17:05:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPZI1eSV5JYG3wEiY4OjiJWJE7qbRYaYzgADLUYA=
- Thread-topic: [Xen-devel] [PATCH 05/60] xen/sched: alloc struct sched_unit for each vcpu
On Fri, 2019-07-19 at 06:56 +0200, Juergen Gross wrote:
> On 18.07.19 19:57, Dario Faggioli wrote:
> > On Tue, 2019-05-28 at 12:32 +0200, Juergen Gross wrote:
> > >
> > However, I don't see much value in not doing what's done here in
> > patch
> > 4 already (it's pretty much only line changed by patch 4 that are
> > being
> > changed again here).
> >
> > Is there a particular reason you think it's important to keep these
> > two
> > patches separated?
>
> Not important, but I thought it would make it more clear.
>
> If you like it better I can merge the two patches.
>
Yes, I'd prefer them merged.
> > Ah, my comment about 'unit' --> 'su' --in case you think it's
> > feasible-
> > - applies to struct members as well, of course, e.g., here:
> >
> I have to disagree here: this is no scheduler private structure, so I
> believe the struct member names should be descriptive. I guess this
> is
> the reason why there are many more struct members named "vcpu" than
> "v".
>
Well, ditto in my last reply to patch 4. And in fact, in scheduling
code, the preference was for 'v'.
But again, let's settle on 'unit', on the basis that the amount of work
necessary to change this is, again, not worth it.
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
