[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 3/6] pci: switch pci_conf_read32 to use pci_sbdf_t
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Tue, 23 Jul 2019 10:15:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fQnA8xrsp2idUz4YvSm6FPENyf1F3thukBnTq3Vcld8=; b=hITW+Pf3LFnR+g0spjkehhcuoJiElixBB68b43ASK24uGH3YqYBzzVsHlWwvSGbuPAnfZX13IjSirrOhCg6T1bAs2Hba2WmL0/suCi1CR8peAX4txb0YDMJnBOMF1VmbKmZ8MKRo0H0YcluLXKiSTS9jOKeIXzN5CU8TFO1w0kCl0fKUmcKjQwYU/f0KtxhYdTJG5uQVZoTrKKzYcXdlG50cfMmQB8Vft70TXXVRNBxp+AeyiqFuGnAAF1szTS9tyEkySmukSStOH4LLTA3JpAn2b9vnSh8s1A8c3kYmCaVI0l/XtdHhHoWC6389Nsh5Nwpmrwt7zEMq+0e5C2bQgw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ls8KXV9Jt9VbNOMbuEzRnwPCQ7yXm+8Hc/Ra526UgBvEThzyI5C0qK/qL5ZHUKPJI/LaERfAaSEYTzH2+3uYpg2CKYhQcxeYgurvT8jTLo6wKx+Qalwqf+DSNNOWqpylvAVRsPO3o+RXuMQzDrbqL+GNFKYDJ22cXTMxO6LBkCvQFS0iokAs28mUNjinSStJ01TC84b4lk2qJDpqQz3K5enJ6723Szkp5LDOUTGKPa2lXGtLo7kxRMltaHUDY0sCszglYYUky5p8mNwFJK8OcoISrAOpNaTLTRoy7tX3z4cd4POAzkfFrSgbVnpmu9Pvfbc7KK3HkCddZhj5zU3RrQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, AndrewCooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, TimDeegan <tim@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Brian Woods <brian.woods@xxxxxxx>
- Delivery-date: Tue, 23 Jul 2019 10:17:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVPjteQR3oEmN0jU2d9qO7/1J66abYAqAA
- Thread-topic: [PATCH v4 3/6] pci: switch pci_conf_read32 to use pci_sbdf_t
On 19.07.2019 16:07, Roger Pau Monne wrote:
> This reduces the number of parameters of the function to two, and
> simplifies some of the calling sites.
>
> While there convert {IGD/IOH}_DEV to be a pci_sbdf_t itself instead of
> a device number.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Acked-by: Brian Woods <brian.woods@xxxxxxx>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with one further remark (easily addressed while committing):
> @@ -128,9 +128,9 @@ static void __init map_igd_reg(void)
> if ( igd_reg_va )
> return;
>
> - igd_mmio = pci_conf_read32(0, 0, IGD_DEV, 0, PCI_BASE_ADDRESS_1);
> + igd_mmio = pci_conf_read32(IGD_DEV, PCI_BASE_ADDRESS_1);
> igd_mmio <<= 32;
> - igd_mmio += pci_conf_read32(0, 0, IGD_DEV, 0, PCI_BASE_ADDRESS_0);
> + igd_mmio += pci_conf_read32(IGD_DEV, PCI_BASE_ADDRESS_0);
There looks to be a stray blank in here.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
