[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 3/6] pci: switch pci_conf_read32 to use pci_sbdf_t
On Tue, Jul 23, 2019 at 10:15:35AM +0000, Jan Beulich wrote: > On 19.07.2019 16:07, Roger Pau Monne wrote: > > This reduces the number of parameters of the function to two, and > > simplifies some of the calling sites. > > > > While there convert {IGD/IOH}_DEV to be a pci_sbdf_t itself instead of > > a device number. > > > > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx> > > Acked-by: Brian Woods <brian.woods@xxxxxxx> > > Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx> > > Acked-by: Jan Beulich <jbeulich@xxxxxxxx> > with one further remark (easily addressed while committing): > > > @@ -128,9 +128,9 @@ static void __init map_igd_reg(void) > > if ( igd_reg_va ) > > return; > > > > - igd_mmio = pci_conf_read32(0, 0, IGD_DEV, 0, PCI_BASE_ADDRESS_1); > > + igd_mmio = pci_conf_read32(IGD_DEV, PCI_BASE_ADDRESS_1); > > igd_mmio <<= 32; > > - igd_mmio += pci_conf_read32(0, 0, IGD_DEV, 0, PCI_BASE_ADDRESS_0); > > + igd_mmio += pci_conf_read32(IGD_DEV, PCI_BASE_ADDRESS_0); > > There looks to be a stray blank in here. Good catch, please adjust on commit if you don't mind. Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |