[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 1/2] xen/sched: fix locking in restore_vcpu_affinity()
- To: Juergen Gross <JGross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Dario Faggioli <dfaggioli@xxxxxxxx>
- Date: Tue, 23 Jul 2019 10:55:06 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Qx0WALFJinnQjwALv6mW8GhJdP30hiH2EsMgcKySE9M=; b=JFGAJpx98qr0QDcHZmheh/X3aWEAXPLLRZVAIsMPfb66SUCPc8ASOBDp/5nR6gw93FTEjEsRG95zBSx4blEau+EqQPSg4ImFCU6MRTYpUa5oUCIFolX58b20azXEnmnn41sLrjTsCY6rl0dXZaFk8BR6R0Db9EIjnIKMp4S23GFQWUcLn5hCOes2ijhYl5eBdc64ATMsJ9SxhscsMlSCgN23al/l1k6wHVORy333iqlYbhFH+nzDzKpIHe4jvRD5oKBkw1FSpszxCqTlo7oI4ndGOcX2Tz3kB8DwhCJ1pHYyxuTfp+ULAc4n542x/YynfXTefhGWfCLCrYrEnEjRmQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FplzYCQ/s6eHy/mZu/yXSe8WwcSroTLSIEEEta/BAa1uXMbGM75y1LmqhH2AWmy7Mrf7+zRAacZTrP4Qg61PAjPY3WJqzVlpphy/wI5qv2FnJtTa8WWReud5gQNkHtY5w00fRAWBBKddacfjzcyWvrIg6y5fJAhJhTmRiqcOPFa6cmKDeOxGwRd/pDW0cKjYGCHj6glTz60FNcYZGENRiru4vTgBdausR0xIaJiaufLzMra9GniIZ78tfnP5QqxoEDIWXT0LfnR/ZpQxkUQTUN1DAdKcxnwq0kWv+N1wnsIYwxF4nzRyNlVyb3dkb2nLGo+vkN4R9DizSqGPacvyVw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=dfaggioli@xxxxxxxx;
- Cc: "george.dunlap@xxxxxxxxxxxxx" <george.dunlap@xxxxxxxxxxxxx>
- Delivery-date: Tue, 23 Jul 2019 10:56:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQTf/MGmpfTe/mkGfuwtT8z8+kabYB7oA
- Thread-topic: [Xen-devel] [PATCH 1/2] xen/sched: fix locking in restore_vcpu_affinity()
On Tue, 2019-07-23 at 11:20 +0200, Juergen Gross wrote:
> Commit 0763cd2687897b55e7 ("xen/sched: don't disable scheduler on
> cpus
> during suspend") removed a lock in restore_vcpu_affinity() which
> needs
> to stay: cpumask_scratch_cpu() must be protected by the scheduler
> lock.
>
And indeed I recall the thing looked weird, and bringing it up... but
then I also managed to convince myself that it wasn't a problem, which
apparently is. :-(
Sorry for having overlooked that.
> restore_vcpu_affinity() is being called by thaw_domains(), so
> with multiple domains in the system another domain might already be
> running and the scheduler might make use of cpumask_scratch_cpu()
> already.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>
Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>
Thanks and Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
