Re: [Xen-devel] [PATCH v3 1/2] xen/x86: cleanup unused NMI/MCE code

[Juergen Gross <jgross@xxxxxxxx>]

On 24.07.19 13:38, Andrew Cooper wrote:
> On 24/07/2019 12:26, Juergen Gross wrote:
> > pv_raise_interrupt() is only called for NMIs these days, so the MCE
> > specific part can be removed. Rename pv_raise_interrupt() to
> > pv_raise_nmi() and NMI_MCE_SOFTIRQ to NMI_SOFTIRQ.
> >
> > Additionally there is no need to pin the vcpu the NMI is delivered
> > to, that is a leftover of (already removed) MCE handling.
> This phrasing is rather awkward to read.
>
> Can I recommend "the vcpu which the NMI" as an alternative, and also
> with the comma turned into a semicolon.
Fine with me.

> >   So remove
> > the pinning, too. Note that pinning was introduced by commit 355b0469a8
> > adding MCE support (with NMI support existing already). MCE using
> > that pinning was removed with commit 3a91769d6e again without cleaning
> > up the code.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>
> The wording tweak can easily be made on commit.
Thanks.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel