[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] x86/pv: Move async_exception_cleanup() into pv/iret.c
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Wed, 24 Jul 2019 11:43:45 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Jlwj4NM4Pv+fL5pSOmVK8lexr2Kt0oK90yuqt3KXlo=; b=Dw4s5jHydGSpGYMOhdxNWWGmmSyP6l9kfZViZMHgLMiLkU+2lrpsE4mpvPCsp1ieZ0d38Ew7SX4F0aBoGxSyzT2vQd/i8Lr+0ZY8Z5sBVzjIH3V4xV8RtFDUUGfC203RQYE4EwEKeQ4MdMEAZCVmtDIkjQcRWjbR9GiKNv14pPyZCri1O9BkPYHTBb33n+dtu+VxdzStb1gnE9F2a8eRyyULE/UNemD9i+xqMnQeXvHM8Irv6OAaNHaCJhpyf0lZN0LfqvX4QEAPaB8X6NgoZptHNsPRMcWTzTz4hieVjr/bdSggDbTJ7wB4Zv5hZFj2vLXNyhLeewD4EgSb32Q08Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVgZQtwC7VyBAbYsQsMcbvxNzsL8pF06O4rNO6WjM+xEGgIda8EEsGd3ljr7KQ+ppTDzHpnIvndrgqPsgyghEYv60GEZM1+lHYFplL6kjhK6M5iZDtrChXayw/snf2Dr5U7S5yzyHbEeiQ0+LK86M8kWRh1uOI9lpiIi8Uftg8U4qbz3XtADukEGZMPraza1IjLnRNLBchk2xqh3eEvnqPJCjhZ7hqcw+K3A2xXZDD2rQGDbljmZ7WmLeFFmVkoq1g5Peb8aXmnMrzaEMwq2ZLWia1X2Xmo44eENPpKqW7o2N37y8HRzq85xk1qjO10bmebHjcAHUKNP7lgjvTcZFg==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Juergen Gross <JGross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 24 Jul 2019 11:45:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQZEPVYSOd4hduEm4xew4+ZUIfabZkFYAgAAL4HuAAAq5gA==
- Thread-topic: [Xen-devel] [PATCH] x86/pv: Move async_exception_cleanup() into pv/iret.c
On 24.07.2019 13:04, Andrew Cooper wrote:
> On 24/07/2019 11:22, Jan Beulich wrote:
>> On 23.07.2019 21:58, Andrew Cooper wrote:
>>> All callers are in pv/iret.c. Move the function and make it static.
>>>
>>> Even before the pinning cleanup, there was nothing which is specific to
>>> operating on curr, so rename the variable back to v.
>> I'm not in full agreement with this: The implication here was (and afaict
>> still is) that uses of / updates to involved vCPU fields are race free.z
>> Feel free to add my ack if you revert back to curr. Otherwise I'd first
>> like to hear your contrary opinion.
>
> We still call this v in plenty of other cases.
And we still call "curr" "v" in many cases where we shouldn't. I think
it is helpful to know when there are such assumptions, ...
> If it wanted to be strictly limited to current then it should
> ASSERT(curr == current) as it doesn't derive curr itself, but with the
> move and being static, this is very obviously a pointless check, given
> the two callers.
... even when it's only a static helper.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
