[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 4/4] xen/percpu: Make DECLARE_PER_CPU() and __DEFINE_PER_CPU() common
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Mon, 29 Jul 2019 13:54:25 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ivPjVcIjKM2OGYukKLViimQc9Wv5oflN8R4h1JIAeE=; b=ndz6tVphC/zmHlgUUae3xXEwduvOkmRFSuOGaskFH94a8KvKtPRApbG754AsM5rxylZw5SNge7OT88+S4K1nV7sKNYl2Y9CDVZgbzSra7W/S+FVQjsSk/Mgb5jlhyAmSvR8QTTIuxxCSc1ejGiWUQMsGJqpfpZDom/G/LE6145G9g44cUNJdrT/4kaytN1vhhM47+OTtIn1WSclDhZmXpbZgCQhckKNYskUFZooDlu9IzgtqlirIUs4g6PmHc4zSVFOhFnkZWnDfuEJ3GuVYZE6TCyQ0g6CP5A5LYZJBnIkZv/yCVX9aSlP4JBbzCe0iubV9EtO9Pn8egIys5q/UsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aYIlAF8LErQX44CPUtCKTk5YIAMTXWMSz14TlAux2im7FAKWoX32/xbCm8IF0hFcnnYPsBwQi23wJQw+lzNVMJBVjjk6hAl0YVyTTxIcpC7shSoq20L0U4kufGdWbfcXxr+pN+DabiIdxqf5NuPmGO1MiXAzYoyaEARlQtZEa/Kz2kKtJLbR0CUKEBaDKZlW8lA7tWU2FOeio7LIAU0UHknPdRQsJL0CQ9sjXMJ+moq/bZLgh1NXySl9pWXNt2/DlwpnkB3q6hDwvFxkC478fIW1rOYVKSaaIxDUb/0UsOGh4pDZU/ZzN4MMM8EUGVBaXFXbsSSOkSm/wRIVk2abRw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: StefanoStabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 29 Jul 2019 14:12:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQ/aLJfmONJuXtEOXa2NkIvPAfabhkz+AgAAGfoKAAAiSgA==
- Thread-topic: [PATCH 4/4] xen/percpu: Make DECLARE_PER_CPU() and __DEFINE_PER_CPU() common
On 29.07.2019 15:23, Andrew Cooper wrote:
> On 29/07/2019 14:00, Jan Beulich wrote:
>> On 26.07.2019 23:08, Andrew Cooper wrote:
>>> --- a/xen/include/xen/percpu.h
>>> +++ b/xen/include/xen/percpu.h
>>> @@ -3,6 +3,12 @@
>>>
>>> #include <asm/percpu.h>
>>>
>>> +#define DECLARE_PER_CPU(type, name) \
>>> + extern __typeof__(type) per_cpu__ ## name
>>> +
>>> +#define __DEFINE_PER_CPU(attr, type, name) \
>>> + attr __typeof__(type) per_cpu_ ## name
>>> +
>>> /*
>>> * Separate out the type, so (int[3], foo) works.
>>> *
>> By moving things here you render stale the remainder of the
>> comment in context above: No per-arch symbol name prefix is going
>> to be possible anymore. I'm not against it, but this comment
>> would then want adjusting. What's not immediately clear to me is
>> whether the two-stage concatenation of an underscore each is then
>> still necessary.
>
> Yes it is still necessary. See the TSS thread for why.
No, that thread doesn't explain it. From an initial look I think
two-stage expansion is still necessary, but it could then be
_ ## name on the first and per_cpu ## name on the second (i.e.
no double underscore in the middle anymore). Of course there may
be reasons why we actually _want_ a double underscore there.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
