[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 4/6] x86/domain: remove the 'oos_off' flag
- To: Paul Durrant <paul.durrant@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Mon, 29 Jul 2019 15:13:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TYlMYtqkzNkH3ZWTS3r2nD7Te2u5+eLRDZQbP2Fg3sE=; b=CFccWTrIbXzvA+xljDsrD9X4fX7Jvq3xh4nNRWCt3xx1K6bQ5XF2PJQfHONwAqP1NatXuvi0iafkvIPEYiyt0zuJ+/7Fd9anJJvYs3on+WH+L7dddITqEHICLF+Ekfd8rTg/Tbq31ZoWpFgTz12zyV1NxZNcR30tNiQuaqkoQteK+yskuRJ3/i9f5Xi+SlwcLQ6vJkMsf5SvAdhRxvQZ8+EPWvpQxNvfu5xVFk1aSOBqyFEHR3aqpUFze+9vsn6ueafMgbDj0RHII6oiLj0UpFRod+cRYyHLxnuUrEQZpYlpqfm6lrVFqa/YPoMYJw9cKqUPdkj0Nro9shp6DZ7NzQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JuufQmnxbd/JCV5CI/Peje6EUnq32foMWS9xo3RbBHPNPylz2BtucR/0SdDbV5ZMlpGrzjCDUKEUOeWaqxKPH65DgVRfoQ4384JvFNIxTB3dZHirszRkqp9SXUgx/1ZJaPdNpf81MXoEWjnr4CHvM6hQqcLNYw82Vz1fpDBxaFf01xfLBbmlFf8CzZ90qfcoHbpQJ1/+RdL0bieA21O7noe/G5iMGxptKAaGEcEWI9hdeetdFKVkDMIAnTQ88Sb7nsu77mTyOI76s1y+xjjlp5iya4qcyJx34a1QdncEgzfUqJE0+ylD7ra6i6F0lCm0j+3nPxGHYSVxwsaTjRV51Q==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Wei Liu <wl@xxxxxxx>, GeorgeDunlap <george.dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 29 Jul 2019 15:34:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVQu50nBwcI3lUmEKPPlnGNTy8pabhuo0A
- Thread-topic: [PATCH v2 4/6] x86/domain: remove the 'oos_off' flag
On 25.07.2019 15:39, Paul Durrant wrote:
> @@ -2523,7 +2522,7 @@ static void sh_update_paging_modes(struct vcpu *v)
> #if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC)
> /* We need to check that all the vcpus have paging enabled to
> * unsync PTs. */
> - if ( is_hvm_domain(d) && !d->arch.paging.shadow.oos_off )
> + if ( is_hvm_domain(d) && !(d->options & XEN_DOMCTL_CDF_oos_off) )
Afaics this is the only evaluation of the flag, i.e. it's HVM
specific. In which cases it should probably follow the model
outlined for patch 3, at which point the is_hvm_domain() here
becomes redundant (i.e. could be demoted to an ASSERT() inside
the if()).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
