Re: [Xen-devel] [PATCH v2 4/6] x86/domain: remove the 'oos_off' flag

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich <JBeulich@xxxxxxxx>
> Sent: 29 July 2019 16:14
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Andrew Cooper 
> <Andrew.Cooper3@xxxxxxxxxx>; Roger Pau Monne
> <roger.pau@xxxxxxxxxx>; George Dunlap <George.Dunlap@xxxxxxxxxx>; Tim 
> (Xen.org) <tim@xxxxxxx>; Wei Liu
> <wl@xxxxxxx>
> Subject: Re: [PATCH v2 4/6] x86/domain: remove the 'oos_off' flag
> 
> On 25.07.2019 15:39, Paul Durrant wrote:
> > @@ -2523,7 +2522,7 @@ static void sh_update_paging_modes(struct vcpu *v)
> >   #if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC)
> >       /* We need to check that all the vcpus have paging enabled to
> >        * unsync PTs. */
> > -    if ( is_hvm_domain(d) && !d->arch.paging.shadow.oos_off )
> > +    if ( is_hvm_domain(d) && !(d->options & XEN_DOMCTL_CDF_oos_off) )
> 
> Afaics this is the only evaluation of the flag, i.e. it's HVM
> specific. In which cases it should probably follow the model
> outlined for patch 3, at which point the is_hvm_domain() here
> becomes redundant (i.e. could be demoted to an ASSERT() inside
> the if()).

Ok, I'll do that.

  Paul

> 
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel