[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 3/5] x86/domain: remove the 'oos_off' flag
- To: Paul Durrant <paul.durrant@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Tue, 30 Jul 2019 11:59:27 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bS9Mr8e8YZoyaWsjDr1J/LEew4Pj42aD7cm9d3K3qPw=; b=PcG/2R/n9KwBDDJrpyRLbyiu6IRvRE4necd/UVqWdidyOIrY68h/rOZM+c2zhGaRDKsP0BjFF3tfAoFa9zhcWuw/HfeJBJurPY8tpXzVrFTo6Xvq5jbGytpBtnmygq6HHFCqifQlKR2Fjql/2p7fltHu/i6HnnBr/K7ZPwuiWPJTEwFKl5FAqMIm1NLZW8dTt4OvP9Y5ALiPsPUZLz0f1zxNHPYar6HWy4njq+uHsudAz437FucUcPm4i7hwhYT6ZY58TSaujBuM6Q+Tweu55mTOEPhm1xZQut0Bbb9Hy9MbzcQOpv9srcGzC4o252U6+ZeH6Drd1M2DIshuAg5rzw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a4tvAXWJqvCQSI8oM3JWYU0gd4zhRf3Vm2n5qJHeq8Kc5f+q5mqYO5kNORHWpKSaqyXl0uY7QV/pVWJMawZiDDIt0hi8X9ADQbJMO2QspJvOeLfO1s/lo+geZdvQveqw2IThJfLnDhbMfPihrywzpUruaRPQWbb7KrQhzGkx82D+2etuHC3JD4F0i8/nDBTo4aMqlD4Y4Xq4nNeN8ygN1fBzfMe7O3X88CBhFA4jyHPTHKs0kzsdw7z1EkQTUrgjsbBbFF1FKjs9RlLj+Zg1ajw9Ez2qoiaFDdW4vL0+hFWF3H3zVYSAgYLuY5nnddcoky6HmTEke5CDB9ZwkJ6XbA==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: Wei Liu <wl@xxxxxxx>, GeorgeDunlap <george.dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 30 Jul 2019 12:02:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVRrrSB+81RPU5GUuqFVso3AyrpKbjDvyA
- Thread-topic: [PATCH v3 3/5] x86/domain: remove the 'oos_off' flag
On 30.07.2019 11:39, Paul Durrant wrote:
> --- a/xen/common/domain.c
> +++ b/xen/common/domain.c
> @@ -313,11 +313,19 @@ static int sanitise_domain_config(struct
> xen_domctl_createdomain *config)
> return -EINVAL;
> }
>
> - if ( !(config->flags & XEN_DOMCTL_CDF_hvm_guest) &&
> - config->flags & XEN_DOMCTL_CDF_hap )
> + if ( !(config->flags & XEN_DOMCTL_CDF_hvm_guest) )
> {
> - dprintk(XENLOG_INFO, "HAP enabled for non-HVM guest\n");
> - return -EINVAL;
> + if ( config->flags & XEN_DOMCTL_CDF_hap )
> + {
> + dprintk(XENLOG_INFO, "HAP enabled for non-HVM guest\n");
> + return -EINVAL;
> + }
> +
> + /*
> + * It is only meaningful for XEN_DOMCTL_CDF_oos_off to be clear
> + * for HVM guests.
> + */
> + config->flags |= XEN_DOMCTL_CDF_oos_off;
> }
I'm not convinced this needs to be in common code, but I also
don't mind, so
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
