[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 5/5] x86/domain: remove the 's3_integrity' flag
- To: Paul Durrant <paul.durrant@xxxxxxxxxx>
- From: Jan Beulich <JBeulich@xxxxxxxx>
- Date: Tue, 30 Jul 2019 12:02:35 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=suse.com;dmarc=pass action=none header.from=suse.com;dkim=pass header.d=suse.com;arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zH2UOb5yFd+CtzorfxsclCidefSYtcDGU++20TwRyFs=; b=n4ZQ9MGPKWB+X4FkU0c0ICdhMhJmQJMf0/8LxDWb1icHe8LcnCZ9C1dlSADquv+iYUJYUrAfKSRLHADF6oBxKgmTN2fs0upmD+4+d9vMV2KNX7plCwWDi4qlMNQRWwiRnKaU9ljjyXbToSoUd0tAcb9qz+r+d8TcVCVd0YvnUws5p3wph6LuGJhFBi2lrM5Hvb46lxRAD4KMPMN/ZZSM4FBmNwmH5XFDSWWXAKkRM/TCWANVIlgr8vi7RCfZwnN1O8AE3eA2efRCZCp2NinLtQ9208tsOUg3DtiFUx87Je6Z2u9DM6eHdCtXX2DDnbWLhHH/7eF7NQ9b5vu6kfKavA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MUuGtJIiOp4ncA1l2djzbI8can0KHqLGZrSz7RqoCbKE8pGs33IJwVnRoBF2c8r3cYZGPShgYfqI/3Ge2hVVHrHc1qnmwBwWmP9fmWJxeK+lppKFI9CI7+qwBRFv8m6Y16Hf/b7wDeVljHX14Tl2sP/n1HkdpNIRRGmx9+uIrWIUWSF1r5LUqLueMO6VVAV9ax3K3gRsUPr1tdKFj3FkrdE4PHYeXz4ZS+kYqvAsJ4wrGdoUiEzSJPG6aBCafNA90OSMP178Eebh3BPgNPzybO0qHDr3OlZzKbZKpsPYx0CehCNHxZaY5tB/2Ax1mFHTP8yDbbNhoqQwLc0ekyaXjQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=JBeulich@xxxxxxxx;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Delivery-date: Tue, 30 Jul 2019 12:12:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVRrrAC6ow8Y7o4EiAXVm7RRDWSKbjD9yA
- Thread-topic: [Xen-devel] [PATCH v3 5/5] x86/domain: remove the 's3_integrity' flag
On 30.07.2019 11:39, Paul Durrant wrote:
> --- a/xen/arch/x86/domain.c
> +++ b/xen/arch/x86/domain.c
> @@ -466,6 +466,13 @@ int arch_sanitise_domain_config(struct
> xen_domctl_createdomain *config)
> return -EINVAL;
> }
>
> + if ( (config->flags & XEN_DOMCTL_CDF_s3_integrity) &&
> + !IS_ENABLED(TBOOT) )
This lacks the CONFIG_ prefix.
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -689,7 +689,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
> .stop_bits = 1
> };
> struct xen_domctl_createdomain dom0_cfg = {
> - .flags = XEN_DOMCTL_CDF_s3_integrity,
> + .flags = IS_ENABLED(TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0,
Same here. With this taken care of (could be done while committing,
but I'm not sure whether this patch is independent of the earlier
ones)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
