Re: [Xen-devel] [PATCH v3 5/5] x86/domain: remove the 's3_integrity' flag

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich <JBeulich@xxxxxxxx>
> Sent: 30 July 2019 13:03
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; Andrew Cooper 
> <Andrew.Cooper3@xxxxxxxxxx>; Roger Pau Monne
> <roger.pau@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>
> Subject: Re: [Xen-devel] [PATCH v3 5/5] x86/domain: remove the 's3_integrity' 
> flag
> 
> On 30.07.2019 11:39, Paul Durrant wrote:
> > --- a/xen/arch/x86/domain.c
> > +++ b/xen/arch/x86/domain.c
> > @@ -466,6 +466,13 @@ int arch_sanitise_domain_config(struct 
> > xen_domctl_createdomain *config)
> >           return -EINVAL;
> >       }
> >
> > +    if ( (config->flags & XEN_DOMCTL_CDF_s3_integrity) &&
> > +         !IS_ENABLED(TBOOT) )
> 
> This lacks the CONFIG_ prefix.
> 
> > --- a/xen/arch/x86/setup.c
> > +++ b/xen/arch/x86/setup.c
> > @@ -689,7 +689,7 @@ void __init noreturn __start_xen(unsigned long mbi_p)
> >           .stop_bits = 1
> >       };
> >       struct xen_domctl_createdomain dom0_cfg = {
> > -        .flags = XEN_DOMCTL_CDF_s3_integrity,
> > +        .flags = IS_ENABLED(TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0,
> 
> Same here. With this taken care of (could be done while committing,
> but I'm not sure whether this patch is independent of the earlier
> ones)
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks. I'll fix it in v4.

  Paul

> 
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel