[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Intel TXT: add reviewer, move to Odd Fixes state

Hi Lars,

On 30/07/2019 12:22, Lars Kurth wrote:

On 30 Jul 2019, at 11:08, George Dunlap <george.dunlap@xxxxxxxxxx <mailto:george.dunlap@xxxxxxxxxx>> wrote:

On 7/30/19 10:54 AM, Julien Grall wrote:
Hi Jan,

On 30/07/2019 10:05, Jan Beulich wrote:
On 30.07.2019 10:54, Julien Grall wrote:
On 7/30/19 9:29 AM, Jan Beulich wrote:
On 30.07.2019 08:56, Lukasz Hawrylko wrote:

+full committers list and Juergen

OK. We should have a separate discussion related to disclaimers: make a formal decision and afterwards document it in the contribution workflow. I agree that this makes sense, and this has been raised by Julien in the past privately related to questions on xen-devel@. It then turned out that Arm folks from China have consistently used disclaimers on contributions to mini-os and unikraft. This has stopped now, which is to Julien's credit. I suggested than that Julien should raise this issue formally as a policy change, which never happened.

I do not believe that we should block any patches from being applied due to disclaimers in absence of an agreed policy. Contributors sign a DCO and that may well override a disclaimer (we do not have access to the legal advice that Greg KH refers to). If there was a serious legal issue, the LF would have contacted all of its projects. And I also could not find any public reference to such an issue. This definitely something where the Advisory Board should have some input.

And in particular this patch also contains no code and should not be blocked on these grounds.

I originally objected on this patch because the disclaimer issue was pointed out 3 versions ago and still not addressed. This then went on the discussion with Jan about the disclaimer.

While reviewer only means you are CC to e-mails, I would at least expect them to understand the process and be able to address comments.

@Lukasz: please take note of this issue for the next time round. It should be easy enough to disable the disclaimer when sending to certain lists

It is not easy enough as you may think ;). At Arm we have to go through a different SMTP server so we bypass exchange.

To move forward:
* There should be a policy discussion

How should I raise it? Do you want a patch again contribution-guidelines?

* There should be AB input
* The outcome should be documented in https://xenproject.org/help/contribution-guidelines/ and the git contribution workflow


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.