Re: [Xen-devel] [PATCH v2 07/48] xen/sched: move per cpu scheduler private data into struct sched_resource

[Dario Faggioli <dfaggioli@xxxxxxxx>]

On Thu, 2019-09-05 at 09:38 +0200, Jan Beulich wrote:
> On 05.09.2019 09:13, Juergen Gross wrote:
> > On 04.09.19 15:48, Jan Beulich wrote:
> > > On 09.08.2019 16:57, Juergen Gross wrote:
> > > >   
> > > > -/*
> > > > - * vcpu is urgent if vcpu is polling event channel
> > > > - *
> > > > - * if urgent vcpu exists, CPU should not enter deep C state
> > > > - */
> > > > -static inline int sched_has_urgent_vcpu(void)
> > > > -{
> > > > -    return atomic_read(&this_cpu(schedule_data).urgent_count);
> > > > -}
> > > 
> > > I
> > > don't suppose there's a way to keep it inline but still drop the
> > > unwanted #include above?
> > 
> > The only alternatives I could think of are:
> > 
> > - Passing the "urgent" indicator via parameter to idle (you didn't
> >    like that)
> > 
> > - Make urgent_count a plain percpu variable
> 
> Named sched_urgent_count or some such, this latter option doesn't
> look too bad to me; not sure what the scheduler maintainers think
> of this, though.
> 
This is ok for me as well.

Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel