Re: [Xen-devel] [PATCH] create-diff-object: more precisely identify .rodata sections

[Lars Kurth <lars.kurth@xxxxxxxxxx>]

On 18/09/2019, 12:15, "Julien Grall" <julien.grall@xxxxxxx> wrote:

    Hi Ian,
    
    On 18/09/2019 11:41, Ian Jackson wrote:
    > Julien Grall writes ("Re: [PATCH] create-diff-object: more precisely 
identify .rodata sections"):
    >> On 18/09/2019 10:52, Wieczorkiewicz, Pawel wrote:
    >>> $ scripts/./add_maintainers.pl -d ~/git/livepatch-build-tools
    >>
    >> '-d' only tells you where the patches files are. The script will look up 
for the
    >> MAINTAINERS file in the current directory.
    > 
    > Hmmm.  I wonder if we could detect this situation somehow.  This will
    > be a common user error I think.
    I think it would be possible for patch modifying file. We could check 
whether 
    the file modified exist in the repo. Though, I am not sure how difficult it 
    would be to implement.
    
That might be doable, but won't be easy as I will essentially need to parse the 
patch    
And it won't be reliable. 

The only workable way of doing this may be to have a strong convention
that requires to use the [REPONAME PATCH] via --subject-prefix when generating 
the 
patch and for add_maintainers.pl to verify this somehow based on the current
directory and the patches.

We already have strong conventions in some cases, e.g. for OSSTEST we always use
[OSSTEST PATCH]. This would potentially be helpful for the CI loop plans aso. 

Assuming there is a git config setting for --subject-prefix then this could be 
made 
to work. I could add a section under [1] to document the convention with the
appropriate git command. We could include a script (e.g. 
xen.git:scrips/git-setup) 
which does this based on the repo name automatically.

Any views?

Lars

[1] 
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Sending_the_patches_to_the_list
 
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel