[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] SVM: correct CPUID event processing
- To: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Razvan COJOCARU <rcojocaru@xxxxxxxxxxxxxxx>
- Date: Thu, 19 Sep 2019 20:36:36 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=bitdefender.com; dmarc=pass action=none header.from=bitdefender.com; dkim=pass header.d=bitdefender.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXb8AX3EJJkzXalH6qXR2Hb8PhXzCHNO+2QXqdnN9Po=; b=folY5sDzj/+pok9OAUOQJq6USDFLkX6OTgD2Qowk6j0m2hp38hH54KdfujYlriOiEyR2/NW0rNCPqFEIqO35Kuj6zccT6ijPhSjx5oP5AM0V8Goxoltxuf1wk7MG8tHQPBn8DNpi3bu1R7mVT2lDU4vU45oeEUGYEg0mFNHO4GbM21kTRLCeT9wW8/2nYHtsTW/fOWkOKz7hJ/CniWKxzwAmM6rC/8O75+eskXF9rueSWxVSIrupNK/7poH2l6pqWBMMoqnXmlzrV0jb8HHHwVrl/g3yyL2kR3vX7p1fYtHAJJ8XTr4AZR6Fscmcw7c7zAVM+P3tXi8YDnKCEXFEhg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iq+EvIZXM1OB0tpWrQgmj9hXCND/v1BEJiblQWN53NiiGKe9zmHAjMfd1YZJA+I8bNVC7/R2eYMXCBMc+XfLM4PhHsabax4XlxfVHpPnc1IME+WKHl/+G65gmAsaai9ZuelCnh6RHQkRNYnzzvIQnLShTBx8k/FsTkdrq4Q988ye8VnF7ZovkW3Khdt4ZJ7ck9SMMiRkEreydK0uH+S00JRJ3I0UA1rRXTX5mqdDF6sj71MyNGZTKMX22IEQmWUd0AmcufTlPYkt7kK4Jg40BdAWcOg2wTJTXx/S6gXqPKnegSrr1v+kg/XD60hAy28qxPQ/+uAeQiFTzlom4kCKEw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=rcojocaru@xxxxxxxxxxxxxxx;
- Cc: Petre Ovidiu PIRCALABU <ppircalabu@xxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Alexandru Stefan ISAILA <aisaila@xxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 19 Sep 2019 20:36:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVbyYpsBrcgD3+X0+1nzjP9UgLIqczdWuA
- Thread-topic: [PATCH] SVM: correct CPUID event processing
On 9/19/19 11:07 PM, Boris Ostrovsky wrote:
> On 9/19/19 6:37 AM, Jan Beulich wrote:
>> hvm_monitor_cpuid() expects the input registers, not two of the outputs.
>>
>> However, once having made the necessary adjustment, the SVM and VMX
>> functions are so similar that they should be folded (thus avoiding
>> further similar asymmetries to get introduced). Use the best of both
>> worlds by e.g. using "curr" consistently. This then being the only
>> caller of hvm_check_cpuid_faulting(), fold in that function as well.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
Acked-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>
Thanks,
Razvan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
