[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v3 13/47] xen/sched: add is_running indicator to struct sched_unit
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Jürgen Groß <jgross@xxxxxxxx>
- Date: Tue, 24 Sep 2019 14:34:08 +0200
- Cc: Tim Deegan <tim@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Julien Grall <julien.grall@xxxxxxx>, Meng Xu <mengxu@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 24 Sep 2019 12:34:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.09.19 14:00, Jan Beulich wrote:
On 24.09.2019 13:47, Jürgen Groß wrote:
On 19.09.19 17:53, Jan Beulich wrote:
On 14.09.2019 10:52, Juergen Gross wrote:
@@ -1673,8 +1676,10 @@ static void schedule(void)
* switch, else lost_records resume will not work properly.
*/
- ASSERT(!next->is_running);
+ ASSERT(!next->sched_unit->is_running);
next->is_running = 1;
+ next->sched_unit->is_running = 1;
Nit: The new field is of type bool, and hence you should write true
and false into it. This may look odd next to the 1 above, but by
the end of the series the two won't sit next to each other anymore.
Indeed. And making vcpu->is_running a bool is another item on my list
for the cleanup.
Is it? It's already bool afaics. It's just the values written to it
which aren't properly true / false.
Saw that after sending my mail. So 0/1 -> false/true is the item to do.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
