[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 2/3] x86/boot: Introduce the kernel_info.setup_type_max



On 2019-10-24 04:48, Daniel Kiper wrote:
> This field contains maximal allowed type for setup_data.
> 
> Now bump the setup_header version in arch/x86/boot/header.S.

Please don't bump the protocol revision here, otherwise we would create
a very odd pseudo-revision of the protocol: 2.15 without SETUP_INDIRECT
support, should patch 3/3 end up getting reverted.

(It is possible to detect, of course, but I feel pretty sure in saying
that bootloaders won't get it right.)

Other than that:

Reviewed-by: H. Peter Anvin (Intel) <hpa@xxxxxxxxx>

        -hpa

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.