Re: [Xen-devel] [XEN PATCH for-4.13] libxl: Fix libxl_retrieve_domain_configuration error path

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Nov 12, 2019 at 02:19:43PM +0000, Anthony PERARD wrote:
> From: Anthony PERARD <anthony.perard@xxxxxxxxx>
> 
> If an error were to happen before the last step, for example the
> domain_configuration is missing, the error wouldn't be check by the
> _end callback.
> 
> Fix that, also initialise `lock' to NULL because the exit path checks
> it.
> 
> The issue shows up when there's a stubdom, and running `xl list -l`
> aborts. Instead, with this patch, `xl list -l` will not list stubdom,
> probably like before.
> 
> Reported-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> Fixes: 61563419257ed40278938db2cce7d697aed44f5d
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

With this patch applied, `xl list -l` no longer crashes and only prints
this error for a stubdomain:
libxl: error: libxl_domain.c:1937:retrieve_domain_configuration_lock_acquired: 
Domain 11:Fail to get domain configuration

The actual HVM is listed correctly. This was the previous behavior on
Xen 4.8 too.

Tested-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

Thanks!

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel