Re: [Xen-devel] [XEN PATCH for-4.13] libxl: Fix libxl_retrieve_domain_configuration error path

[Wei Liu <wl@xxxxxxx>]

On Tue, Nov 12, 2019 at 02:19:43PM +0000, Anthony PERARD wrote:
> From: Anthony PERARD <anthony.perard@xxxxxxxxx>
> 
> If an error were to happen before the last step, for example the
> domain_configuration is missing, the error wouldn't be check by the

check -> checked

> _end callback.
> 
> Fix that, also initialise `lock' to NULL because the exit path checks
> it.
> 
> The issue shows up when there's a stubdom, and running `xl list -l`
> aborts. Instead, with this patch, `xl list -l` will not list stubdom,
> probably like before.
> 
> Reported-by: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> Fixes: 61563419257ed40278938db2cce7d697aed44f5d
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Acked-by: Wei Liu <wl@xxxxxxx>

I also have a look at other callbacks. The _end one is the only one that
missed this early exit path.

Juergen, this should definitively be in 4.13 since it fixes a bug
introduced in this cycle.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel