[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range
- To: "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien.grall@xxxxxxx" <julien.grall@xxxxxxx>, "Volodymyr_Babchuk@xxxxxxxx" <Volodymyr_Babchuk@xxxxxxxx>
- From: Peng Fan <peng.fan@xxxxxxx>
- Date: Fri, 22 Nov 2019 07:44:10 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iQOURUxil261Yr8eiRHq5OhflJZm3PhDYnhyhniwnmc=; b=OEjyoU8UQFpOBGqPnqBWW/CNlRdCXayusQ3uANWFxpLlff2VgE5jjtT+ilWt1R3yJ93hEDRD0uKUWkTJo4IEOyI4wZRy3v1tcxmgJW3dog609/0GVv7S01Pc0Rck+Pin37atlzIf99BBLijfAX0z1XLXdXckMkX+ZqqOEDX/oNeTaC9v0wgCIaTkqTRQT+zPF5M1Eo0/59NlabEdeQ4pTTw/+cT0AKaph11jcTnCkAu9hxZEVmudBm4tqOYVaM8zHustL8OcT3mJCbaC8dTJELrSX3fFtL8jV2ku2bckFkQiWjc8YdYeIaaUtGXkaa28pchq7oDRHXoKAM5n4EYusA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FNx11GtA0Z3Cl4jQ1W6SuMeAdEPObpuL6LrtRXTR25OJXtq/JSq6pQr01lUzmmsl2cxLe4XoT2yYBRMTfypFvRj/My5Tm/0SY+wCdRo46vhZsDnRtfpMjmFQtZkasSkyouISlZlHw7KvZf18sF1PzvAhyseYWvM8BiiOBCqiKHQhCvqd1fUHoyCqPBMpJKc9vX9VoPczpSRQwpmwetegzf7hOMh4tbAgMS153W1Obt6EOme/TNwnb//uTioF9ay/pl+B4J7B2kJIR4GSX0fnTjXxikrQg2pnuRML1mbgj6O6Oi1+/Q5Hl+66ug7kUu6G56TzLT/woPF9+ivMjPoeZw==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=peng.fan@xxxxxxx;
- Cc: Peng Fan <peng.fan@xxxxxxx>, Alice Guo <alice.guo@xxxxxxx>, "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>
- Delivery-date: Fri, 22 Nov 2019 07:44:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVoQigeBpkjI1AYkOsm95VpW/YYQ==
- Thread-topic: [PATCH V2] arch: arm: vgic-v3: fix GICD_ISACTIVER range
The end should be GICD_ISACTIVERN not GICD_ISACTIVER,
and also print a warning for the unhandled read.
Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
---
V2:
Add a warning message
xen/arch/arm/vgic-v3.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 422b94f902..a15b9f6441 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -706,7 +706,10 @@ static int __vgic_v3_distr_common_mmio_read(const char
*name, struct vcpu *v,
goto read_as_zero;
/* Read the active status of an IRQ via GICD/GICR is not supported */
- case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVER):
+ case VRANGE32(GICD_ISACTIVER, GICD_ISACTIVERN):
+ printk(XENLOG_G_ERR "%pv: vGICD: unhandled read from ISACTIVER%d\n",
+ v, (reg - GICD_ISACTIVER) / 4);
+ goto read_as_zero;
case VRANGE32(GICD_ICACTIVER, GICD_ICACTIVERN):
goto read_as_zero;
--
2.16.4
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
