Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Fri, Nov 29, 2019 at 12:51:47PM +0000, Durrant, Paul wrote:
> > -----Original Message-----
> > From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > Sent: 29 November 2019 12:46
> > I'm not sure what was the intention with the new function
> > xlu_cfg_get_bounded_long(), but I don't think libxlu is the right place
> > for it. That function is only going to make it harder for users to find
> > mistakes in the config file. If `n' value is out of bound, it will only
> > get ignored, and xl will keep going. I think xlu_cfg should only be a
> > parser (and can check for syntax error).
> > 
> > Can you move that function to xl?
> > 
> 
> I can, but why is this not considered useful in libxl? The call returns 
> failure for an out-of-bounds check.

Sorry that the repo layout is confusing, but libxl != libxlu. libxl
doesn't even use libxlu!

> If xl currently chooses to treat EINVAL as ENOENT then that's xl's bug to 
> deal with.

The general use of xlu_cfg_get_*() that treats all errors as ENOENT in
xl is an issue, I think, but this patch does the same thing and treat
EINVAL as ENOENT when using the newly introduced
xlu_cfg_get_bounded_long() function. I don't think that an xl bug to
deal with, but an issue with the patch.

Cheers,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel