Re: [Xen-devel] [PATCH-for-4.13 v5] Rationalize max_grant_frames and max_maptrack_frames handling

["Durrant, Paul" <pdurrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Sent: 29 November 2019 13:52
> To: Durrant, Paul <pdurrant@xxxxxxxxxx>
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx; George Dunlap
> <george.dunlap@xxxxxxxxxx>; Ian Jackson <ian.jackson@xxxxxxxxxxxxx>; Wei
> Liu <wl@xxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; George Dunlap
> <George.Dunlap@xxxxxxxxxxxxx>; Jan Beulich <jbeulich@xxxxxxxx>; Julien
> Grall <julien@xxxxxxx>; Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>;
> Stefano Stabellini <sstabellini@xxxxxxxxxx>; Marek Marczykowski-Górecki
> <marmarek@xxxxxxxxxxxxxxxxxxxxxx>; Volodymyr Babchuk
> <Volodymyr_Babchuk@xxxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Subject: Re: [PATCH-for-4.13 v5] Rationalize max_grant_frames and
> max_maptrack_frames handling
> 
> On Fri, Nov 29, 2019 at 12:51:47PM +0000, Durrant, Paul wrote:
> > > -----Original Message-----
> > > From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> > > Sent: 29 November 2019 12:46
> > > I'm not sure what was the intention with the new function
> > > xlu_cfg_get_bounded_long(), but I don't think libxlu is the right
> place
> > > for it. That function is only going to make it harder for users to
> find
> > > mistakes in the config file. If `n' value is out of bound, it will
> only
> > > get ignored, and xl will keep going. I think xlu_cfg should only be a
> > > parser (and can check for syntax error).
> > >
> > > Can you move that function to xl?
> > >
> >
> > I can, but why is this not considered useful in libxl? The call returns
> failure for an out-of-bounds check.
> 
> Sorry that the repo layout is confusing, but libxl != libxlu. libxl
> doesn't even use libxlu!

Oh, that is confusing... there is code under tools/libxl that is not use by 
libxl; totally sane, of course.

> 
> > If xl currently chooses to treat EINVAL as ENOENT then that's xl's bug
> to deal with.
> 
> The general use of xlu_cfg_get_*() that treats all errors as ENOENT in
> xl is an issue, I think, but this patch does the same thing and treat
> EINVAL as ENOENT when using the newly introduced
> xlu_cfg_get_bounded_long() function. I don't think that an xl bug to
> deal with, but an issue with the patch.
> 

True, but I don't think that makes things strictly worse. I'll send v6 with 
extra checks though.

  Paul

> Cheers,
> 
> --
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel