Re: [Xen-devel] [PATCH v4 0/9] Add alternative API for Xen PTEs

["Xia, Hongyan" <hongyxia@xxxxxxxxxx>]

Okay let me be explicit this time. Cross checked with mails from
lore.kernel.org, issues not touched from v3 to v4:

- _new or not _new
- splitting map_pages_to_xen; introduction of labels. Although I just
responded to these two issues.
- const not added to suggested variables since a lot of them are stuck
with the old API for now. I can review relevant functions and const
qualify other applicable ones.

Hongyan

On Thu, 2019-12-05 at 10:51 +0100, Jan Beulich wrote:
> On 05.12.2019 10:41, Xia, Hongyan wrote:
> > I have addressed the comments that I can find in the archive.
> 
> That's still pretty vague - is there reason to assume you were
> not able to find some comments there?
> 
> > Some big
> > debates (like _new or not _new, whether to modularise
> > map_pages_to_xen)
> > have not been touched.
> 
> The _new suffix discussion you've meanwhile responded you,
> which is therefore fine. The modularization question, otoh,
> I don't recall seeing any reply for, and hence for now I'd
> skip re-reviewing the respective patches. Furthermore, is
> your use of "like" implying there were more than the two
> examples you gave? As much as I can understand difficulties
> on your part resulting from your email issues, please also
> understand my reservations regarding having to re-do things
> where quite a bit of time had already been invested into.
> 
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel