Re: [Xen-devel] [PATCH] CODING_STYLE: Document how to handle unexpected conditions

[Julien Grall <julien@xxxxxxx>]

Hi George,

On 07/01/2020 12:02, George Dunlap wrote:
> It's not always clear what the best way is to handle unexpected
> conditions: whether with ASSERT(), domain_crash(), BUG_ON(), or some
> other method.  All methods have a risk of introducing security
> vulnerabilities and unnecessary instabilities to production systems.
>
> Provide guidelines for different options and when to use them.
>
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> ---
> v4:
> - s/guest should/guests shouldn't/;
> - Add a note about the effect of domain_crash() further up the stack.
> v3:
> - A number of minor edits
> - Expand on domain_crash a bit.
> v2:
> - Clarify meaning of "or" clause
> - Add domain_crash as an option
> - Make it clear that ASSERT() is not an error handling mechanism.
>
> CC: Ian Jackson <ian.jackson@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Konrad Wilk <konrad.wilk@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
Acked-by: Julien Grall <julien@xxxxxxx>

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel