Re: [Xen-devel] [PATCH] x86: fix off-by-one error when printing memory ranges

[Jan Beulich <jbeulich@xxxxxxxx>]

On 04.02.2020 17:55, Wei Liu wrote:
> Signed-off-by: Wei Liu <liuwe@xxxxxxxxxxxxx>
> ---
>  xen/arch/x86/e820.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/e820.c b/xen/arch/x86/e820.c
> index b9f589cac3..d67387f137 100644
> --- a/xen/arch/x86/e820.c
> +++ b/xen/arch/x86/e820.c
> @@ -94,7 +94,7 @@ static void __init print_e820_memory_map(struct e820entry 
> *map, unsigned int ent
>      for (i = 0; i < entries; i++) {
>          printk(" %016Lx - %016Lx ",
>                 (unsigned long long)(map[i].addr),
> -               (unsigned long long)(map[i].addr + map[i].size));
> +               (unsigned long long)(map[i].addr + map[i].size) - 1);

Why was this an error? If we used [,] like Linux does - sure.
But we don't. The presentation, without looking at the source,
simply leaves open whether this was meant to be [,] or [,).
And it continues to be left open with the adjustment made.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel