Re: [Xen-devel] [PATCH 1/2] x86/shim: suspend and resume platform time correctly

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Feb 04, 2020 at 03:40:24PM +0000, Igor Druzhinin wrote:
> Similarly to S3, platform time needs to be saved on guest suspend
> and restored on resume respectively. This should account for expected
> jumps in PV clock counter value after resume. time_suspend/resume()
> are safe to use in PVH setting as is since any existing operations
> with PIT that they do would simply be ignored there.

There's also an attempt to fiddle with HPET, which I think it's just a
no-op.

Just to be on the safe side it might be better to pass a new parameter
to time_resume in order to signal whether PIT/HPET should even be
attempted to be resumed?

The rest LGTM, thanks for tracking this down.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel