|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] timeout: adjust timeout when running nested tests
Roger Pau Monne writes ("Re: [PATCH] timeout: adjust timeout when running
nested tests"):
> On Wed, Apr 01, 2020 at 05:45:21PM +0100, Ian Jackson wrote:
> > I think this wannts to be // not ||. If you agree I will fix this up
> > and commit.
>
> Yes, I agree.
Thanks, done and pushed.
> > Since what this does otherwise is to take all baremetal hosts and give
> > them an empty Host hash due to autovivification.
> >
> > > + if ($nestinglvl) {
> > > + $adjust->(1 << $nestinglvl, "nesting level");
> > > + }
> >
> > I still think the use of << is very odd and I can't resist moaning
> > about it. But you're the patch author so I will let you choose the
> > style here.
>
> Feel free to change to 2 ** $nestinglvl at commit, you are the
> maintainer so it's important that you can read the code easily.
I'll keep the version you tested rather than messing about with it...
Ian.
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |