[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] sched: print information about scheduler granularity



On 16.04.20 18:47, Dario Faggioli wrote:
On Thu, 2020-04-16 at 11:25 +0200, Jürgen Groß wrote:
On 16.04.20 11:20, Sergey Dyasli wrote:
On 16/04/2020 09:57, Jürgen Groß wrote:

The xen commandline ins part of the boot messages and is
contained
in the "xl info" output.

It's true that you can see "sched-gran=core" in "xl info" output.
But that's
just the switch - not the end result. A user might want to verify
that he did
everything correctly and core-scheduling mode has indeed been
enabled.

I'm not opposed to your patch, but as soon as we have per-cpupool
granularity it should be reverted again.

Why reverted? Each cpupool dumps its own scheduling information. With
per-pool granularity, we'll see something like

cpupool: Pool-A
Scheduler: SMP Credit Scheduler (credit)
Scheduling granularity: cpu
...
cpupool: Pool-B
Scheduler: SMP Credit Scheduler (credit)
Scheduling granularity: core

etc.

Or am I missing something?

"Reworking" might have been a better wording.

The patch is looking only at the global variable opt_sched_granularity
for deciding which granularity to print out.


Juergen



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.