[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/8] Fix build with using OCaml 4.06.1 and -safe-string

Hi Christian,

On 16/04/2020 14:25, Christian Lindig wrote:

The changes in the OCaml C stubs look good to me. They don't really touch the 
interface but are mostly concerned with types on the C side by adding casts, 
const, and so on. The extended error handling is an improvement.

Thank you for the review! I will commit the rest of the series.

As an aside, the acked-by was adding as part of the signature.

Not sure whether this is intentional but some e-mail clients are hiding the signature so the acked-by can be easily missed.


Julien Grall



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.