[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] golang/xenlight: add DeviceNicAdd/Remove wrappers

> I feel like I want to say here what it is you actually have to fill in to 
> remove the nic; but after 10 minutes of poking around the code, I’m not 
> actually sure myself. :-)  (I think it *might* be just Devid and 
> BackendDomid.)

IIRC, you can use just the MAC or devid. I was using just the MAC when
I tested it out.

> So I’ll give this for now:
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
> And if I find it before I finish reviewing the end of the series, we can 
> check it in and look at improving the documentation later.

Sounds good, thanks!




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.